Protect Task.ptraceSeized with TaskSet mutex and Signal mutex. #11584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl740839780
branch
2 times, most recently
from
c907330 to
de7ddc0
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test/cl740839780
branch
4 times, most recently
from
5eb904f to
6b49bad
Compare
Previously Task.ptraceSeized was protected only by TaskSet mutex, but some pathways incorrectly modified the field without holding the lock, leading to data races. This CL changes the locking so that TaskSet and Signal mutexes are required to write Task.ptraceSeized, but only one of them must be held to read Task.ptraceSeized. Reported-by: syzbot+b0de1abe368849ca2d00@syzkaller.appspotmail.com PiperOrigin-RevId: 742317413
copybara-service
bot
force-pushed
the
test/cl740839780
branch
from
6b49bad to
8221e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect Task.ptraceSeized with TaskSet mutex and Signal mutex.
Previously Task.ptraceSeized was protected only by TaskSet mutex, but some
pathways incorrectly modified the field without holding the lock, leading to
data races.
This CL changes the locking so that TaskSet and Signal mutexes are required to
write Task.ptraceSeized, but only one of them must be held to read
Task.ptraceSeized.
Reported-by: syzbot+b0de1abe368849ca2d00@syzkaller.appspotmail.com