sentry/control: fix Lifecycle.Shutdown() panics #11773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl764790151
branch
9 times, most recently
from
6bc309c to
62994cf
Compare
close() on a nil channel panics, so this command panics unconditionally in runsc (where boot.controller.registerHandlers() passes Lifecycle.ShutdownCh == nil). close() on a closed channel also panics, so issuing this command twice panics unconditionally. PiperOrigin-RevId: 766739255
copybara-service
bot
force-pushed
the
test/cl764790151
branch
from
62994cf to
bdb79d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry/control: fix Lifecycle.Shutdown() panics
close() on a nil channel panics, so this command panics unconditionally in
runsc (where boot.controller.registerHandlers() passes Lifecycle.ShutdownCh ==
nil). close() on a closed channel also panics, so issuing this command twice
panics unconditionally.