overlayfs: Do not SetStat() UID/GID for newly created file. #11796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl767693990
branch
from
cdd0fb8 to
c4ad3c8
Compare
Instead, use a credentials object which has the target UID/GID set as the EffectiveKUID/EffectiveKGID. This will ensure that the file is created with the right owners. This is consistent with what Linux does. This avoids making unnecessary SetStatAt() calls to the VFS, which may incur additional RPCs. This commit additionally fixes the following bugs: - When parent directory has the SGID bit set, newly created symlinks should inherit the GID from the parent directory. This was not happening earlier. - There was a bug in newChildOwnerStat() where it was checking an uninitialized `stat.Mode` to check if the newly created file is a directory or not. That would always evaluate to false, so child directories would not have the SGID bit set. PiperOrigin-RevId: 768239284
copybara-service
bot
force-pushed
the
test/cl767693990
branch
from
c4ad3c8 to
f3f2ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overlayfs: Do not SetStat() UID/GID for newly created file.
Instead, use a credentials object which has the target UID/GID set as the
EffectiveKUID/EffectiveKGID. This will ensure that the file is created with the
right owners. This is consistent with what Linux does. This avoids making
unnecessary SetStatAt() calls to the VFS, which may incur additional RPCs.
This commit additionally fixes the following bugs:
inherit the GID from the parent directory. This was not happening earlier.
stat.Modeto check if the newly created file is a directory or not. Thatwould always evaluate to false, so child directories would not have the SGID
bit set.