Fix stringification code for headerType (under pkg/tcpip/stack).
#12068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed [when a new headertype (virtionetheader) was added](c06c9de#diff-18df233b2766aad71cf642c99506a0f1b3001e1cff462e57d0deb7c4839301c8, but the `_headerType_index` array wasn't updated correctly. I've fixed this by re-running stringer: ``` cd pkg/tcpip/stack go run golang.org/x/tools/cmd/stringer -type headerType . ```
copybara-service
bot
force-pushed
the
test/cl797469761
branch
from
ddbf00b to
aba788d
Compare
…or-headertype PiperOrigin-RevId: 797493764
copybara-service
bot
force-pushed
the
test/cl797469761
branch
from
aba788d to
db0e3ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stringification code for
headerType(underpkg/tcpip/stack).This was changed when a new headertype (virtionetheader) was added, but the
_headerType_indexarray wasn't updated correctly.I've fixed this by re-running stringer:
I found this when I was debugging a crash during memory-snapshot restoration. The error message says:
panic: consume must not be called twice: type ernetworkHeader:gvisor/pkg/tcpip/stack/packet_buffer.go
Line 347 in c07c524
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12064 from abhagwat:apoorva/fix-stringification-for-headertype 88a33a9