nogo: add more staticcheck analyzers#12598
Open
tamird wants to merge 32 commits intogoogle:masterfrom
Open
Conversation
tamird
force-pushed
the
nogo-more-checks
branch
from
36970ec to
0fa9fad
Compare
ayushr2
approved these changes
Feb 8, 2026
ayushr2
reviewed
Feb 8, 2026
ayushr2
reviewed
Feb 8, 2026
tamird
force-pushed
the
nogo-more-checks
branch
2 times, most recently
from
c83b596 to
4f17a0e
Compare
tamird
force-pushed
the
nogo-more-checks
branch
from
4f17a0e to
9924852
Compare
nixprime
reviewed
Feb 9, 2026
Member
nixprime
left a comment
nixprime
left a comment
There was a problem hiding this comment.
Fix QF1008 violations and drop suppression
IMO this rule makes the code worse rather than better.
tamird
force-pushed
the
nogo-more-checks
branch
from
9924852 to
bed421a
Compare
Contributor
Author
Fair. I've split it out of this PR so we can get the less controversial bits merged. |
Add Go version plumbing to support version-gated lints.
tamird
force-pushed
the
nogo-more-checks
branch
from
bed421a to
a50651c
Compare
Contributor
Author
|
Gentle ping here folks. Anything I can do to nudge this along? |
Member
|
Sorry, this is still pending on internal review :( |
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Please see individual commits: - **nogo: add more staticcheck analyzers** - **Fix QF1001 violations and drop suppression** - **Fix QF1002 violations and drop suppression** - **Fix QF1003 violations and drop suppression** - **Fix QF1004 violations and drop suppression** - **Fix QF1005 violations and drop suppression** - **Fix QF1006 violations and drop suppression** - **Fix QF1007 violations and drop suppression** - **Fix QF1008 violations and drop suppression** - **Fix QF1012 violations and drop suppression** - **Fix S1000 violations and drop suppression** - **Fix S1002 violations and drop suppression** - **Fix S1003 violations and drop suppression** - **Fix S1004 violations and drop suppression** - **Fix S1005 violations and drop suppression** - **Fix S1007 violations and drop suppression** - **Fix S1008 violations and drop suppression** - **Fix S1009 violations and drop suppression** - **Fix S1011 violations and drop suppression** - **Fix S1012 violations and drop suppression** - **Fix S1016 violations and drop suppression** - **Fix S1019 violations and drop suppression** - **Fix S1020 violations and drop suppression** - **Fix S1021 violations and drop suppression** - **Fix S1023 violations and drop suppression** - **Fix S1024 violations and drop suppression** - **Fix S1025 violations and drop suppression** - **Fix S1034 violations and drop suppression** - **Fix S1030 violations and drop suppression** - **Fix S1039 violations and drop suppression** - **Fix S1033 violations and drop suppression** - **Fix S1040 violations and drop suppression** FUTURE_COPYBARA_INTEGRATE_REVIEW=#12598 from tamird:nogo-more-checks a50651c PiperOrigin-RevId: 868765670
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Please see individual commits: - **nogo: add more staticcheck analyzers** - **Fix QF1001 violations and drop suppression** - **Fix QF1002 violations and drop suppression** - **Fix QF1003 violations and drop suppression** - **Fix QF1004 violations and drop suppression** - **Fix QF1005 violations and drop suppression** - **Fix QF1006 violations and drop suppression** - **Fix QF1007 violations and drop suppression** - **Fix QF1008 violations and drop suppression** - **Fix QF1012 violations and drop suppression** - **Fix S1000 violations and drop suppression** - **Fix S1002 violations and drop suppression** - **Fix S1003 violations and drop suppression** - **Fix S1004 violations and drop suppression** - **Fix S1005 violations and drop suppression** - **Fix S1007 violations and drop suppression** - **Fix S1008 violations and drop suppression** - **Fix S1009 violations and drop suppression** - **Fix S1011 violations and drop suppression** - **Fix S1012 violations and drop suppression** - **Fix S1016 violations and drop suppression** - **Fix S1019 violations and drop suppression** - **Fix S1020 violations and drop suppression** - **Fix S1021 violations and drop suppression** - **Fix S1023 violations and drop suppression** - **Fix S1024 violations and drop suppression** - **Fix S1025 violations and drop suppression** - **Fix S1034 violations and drop suppression** - **Fix S1030 violations and drop suppression** - **Fix S1039 violations and drop suppression** - **Fix S1033 violations and drop suppression** - **Fix S1040 violations and drop suppression** FUTURE_COPYBARA_INTEGRATE_REVIEW=#12598 from tamird:nogo-more-checks a50651c PiperOrigin-RevId: 868765670
ayushr2
reviewed
Feb 17, 2026
Comment on lines
+270
to
+278
|
|
||
| QF1001: # Apply De Morgan’s law | ||
| # Controversial. | ||
| internal: | ||
| exclude: [".*"] | ||
| QF1008: # Omit embedded fields from selector expression | ||
| # Controversial. | ||
| internal: | ||
| exclude: [".*"] |
Collaborator
There was a problem hiding this comment.
Why add these at all if these are going to be excluded on .*?
Contributor
Author
There was a problem hiding this comment.
What does that code look like, that doesn't add them? have a look at tools/nogo/check/analyzers.go, we aren't adding these by name.
Collaborator
There was a problem hiding this comment.
What does that code look like, that doesn't add them?
The version of nogo.yaml at HEAD does not reference these (QF1001 and QF1008). I see you have an intermediate commit to "move and explain suppression": 2744619 and d171aaa. I don't know which other commit in this PR added these to nogo.yaml in the first place.
But what I was suggesting was just removing these lines altogether?
Contributor
Author
There was a problem hiding this comment.
Removing these lines amounts to enabling these linters. The suppressions were added in the very first commit.
I changed that commit to move these to the bottom so that the later commits would apply without merge conflicts.
The bottom line is that we need these here because we want these lints off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see individual commits: