devpts: Check ISIG flag before generating signals for VINTR/VSUSP/VQUIT#12786
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Mar 25, 2026
Merged
Conversation
Signal characters (Ctrl-C/Z/\) unconditionally generated signals regardless of the ISIG flag. Linux only generates these signals when L_ISIG(tty) is true (n_tty.c:n_tty_receive_char_special). Also fix signal characters leaking into the read buffer — Linux consumes them in n_tty_receive_signal_char() and never delivers them to the reading process. Signed-off-by: Tan Yifeng <yiftan@tencent.com>
Contributor
Author
|
The babi text editor's test suite reproduces this issue out of the box. Its Run a single test case to reproduce quickly: docker run --rm --runtime=runsc python:3.11-slim bash -c "
apt-get update -qq && apt-get install -y -qq tmux git > /dev/null 2>&1 &&
pip install -q pytest hecate coverage covdefaults &&
git clone --depth 1 https://github.com/asottile/babi.git /tmp/babi &&
cd /tmp/babi && pip install -e . -q &&
python -m pytest tests/features/replace_test.py -k 'test_replace_cancel[tmux-Enter]' --no-header -rN --tb=line
"Before fix — FAILED ( After fix — PASSED ( |
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
Signal characters (Ctrl-C/Z/\) unconditionally generated signals regardless of the ISIG flag. Linux only generates these signals when L_ISIG(tty) is true (n_tty.c:n_tty_receive_char_special). Also fix signal characters leaking into the read buffer — Linux consumes them in n_tty_receive_signal_char() and never delivers them to the reading process. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12786 from tanyifeng:devpts-isig-check 0a1922c PiperOrigin-RevId: 889267158
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 25, 2026
Signal characters (Ctrl-C/Z/\) unconditionally generated signals regardless of the ISIG flag. Linux only generates these signals when L_ISIG(tty) is true (n_tty.c:n_tty_receive_char_special). Also fix signal characters leaking into the read buffer — Linux consumes them in n_tty_receive_signal_char() and never delivers them to the reading process. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12786 from tanyifeng:devpts-isig-check 0a1922c PiperOrigin-RevId: 889267158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal characters (Ctrl-C/Z/) unconditionally generated signals regardless of the ISIG flag. Linux only generates these signals when L_ISIG(tty) is true (n_tty.c:n_tty_receive_char_special).
Also fix signal characters leaking into the read buffer — Linux consumes them in n_tty_receive_signal_char() and never delivers them to the reading process.