vfs: return EOPNOTSUPP for FICLONE/FICLONERANGE/FIDEDUPERANGE#12862
Merged
copybara-service[bot] merged 2 commits intomasterfrom Apr 3, 2026
Merged
vfs: return EOPNOTSUPP for FICLONE/FICLONERANGE/FIDEDUPERANGE#12862copybara-service[bot] merged 2 commits intomasterfrom
copybara-service[bot] merged 2 commits intomasterfrom
Conversation
Linux returns EOPNOTSUPP when a filesystem does not support reflink. gVisor returned ENOTTY, breaking programs like syncthing that rely on EOPNOTSUPP to gracefully fall back to regular copy. Handle these ioctls in FileDescriptionDefaultImpl.Ioctl() so all filesystems without custom Ioctl get the correct errno automatically. Signed-off-by: Tan Yifeng <yiftan@tencent.com>
copybara-service
bot
force-pushed
the
test/cl893757418
branch
from
936c221 to
3762213
Compare
PiperOrigin-RevId: 893786981
copybara-service
bot
force-pushed
the
test/cl893757418
branch
from
3762213 to
b03a9f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vfs: return EOPNOTSUPP for FICLONE/FICLONERANGE/FIDEDUPERANGE
Linux returns EOPNOTSUPP when a filesystem does not support reflink. gVisor returned ENOTTY, breaking programs like syncthing that rely on EOPNOTSUPP to gracefully fall back to regular copy.
Handle these ioctls in FileDescriptionDefaultImpl.Ioctl() so all filesystems without custom Ioctl get the correct errno automatically.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12853 from tanyifeng:vfs-ficlone-eopnotsupp 7435a6c