Adds missing video encoding NVIDIA ioctl classes#12867
Adds missing video encoding NVIDIA ioctl classes#12867luiscape wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ayushr2 happy to resubmit this PR if the Google CLA issue above is hard to fix. |
|
The CLA check is unhappy about your git commit author, which is set to |
94e288e to
defcad3
Compare
|
@EtiennePerot thanks. Fixed! |
|
Hi, |
|
Be sure to run the tests in https://github.com/google/gvisor/tree/master/pkg/sentry/devices/nvproxy#step-3-account-for-abi-changes when modifying the version map (adding new ioctls or version support). |
| _ structs.HostLayout | ||
| Size uint32 | ||
| ProhibitMultipleInstances uint32 | ||
| EngineInstance uint32 |
There was a problem hiding this comment.
I think we are missing the uint32 padding at the end. The adding is added to make the struct 64-byte aligned. See similar padding in
gvisor/pkg/abi/nvgpu/classes.go
Line 176 in 836cff5
There was a problem hiding this comment.
We don't need to add padding on this one. Tests will fail after adding padding, so I'm leaving this one as is.
nvproxy_driver_parity_test.go:128: struct "NV_NVJPG_ALLOCATION_PARAMETERS" has different definitions between nvproxy and driver: mismatched sizes for struct "NV_NVJPG_ALLOCATION_PARAMETERS" between nvproxy (16) and driver (12) (bytes)
|
Thank you for the reviews. Taking a look. |
This adds missing NVJPG (JPEG encoding/decoding) and optical flow classes. Both are used in video-processing workflows, hence thet video capability conditional.
defcad3 to
bf9b0ea
Compare
|
@ayushr2 updated with your proposed changes. Thank you. |
This adds missing NVJPG (JPEG encoding/decoding) and optical flow classes. Both are used in video-processing workflows, hence the video capability conditional.