pty: Implement TCSBRK and TCFLSH#12914
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Apr 10, 2026
Merged
Conversation
Linux PTYs accept TCSBRK as a no-op and implement TCFLSH by flushing the input and/or output queues. gVisor returned ENOTTY, which breaks programs such as pyserial during terminal setup. Handle TCSBRK in the PTY ioctl paths and route TCFLSH through lineDiscipline.tcFlush(), including packet mode flush notification and queue wakeups, to match Linux PTY semantics. Signed-off-by: Tan Yifeng <yiftan@tencent.com>
tanyifeng
force-pushed
the
pty-tcsbrk-tcflsh
branch
from
2f0ee0f to
e00ca0a
Compare
EtiennePerot
approved these changes
Apr 10, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Linux PTYs accept TCSBRK as a no-op and implement TCFLSH by flushing the input and/or output queues. gVisor returned ENOTTY, which breaks programs such as pyserial during terminal setup. Handle TCSBRK in the PTY ioctl paths and route TCFLSH through lineDiscipline.tcFlush(), including packet mode flush notification and queue wakeups, to match Linux PTY semantics. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12914 from tanyifeng:pty-tcsbrk-tcflsh e00ca0a PiperOrigin-RevId: 897772400
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Linux PTYs accept TCSBRK as a no-op and implement TCFLSH by flushing the input and/or output queues. gVisor returned ENOTTY, which breaks programs such as pyserial during terminal setup. Handle TCSBRK in the PTY ioctl paths and route TCFLSH through lineDiscipline.tcFlush(), including packet mode flush notification and queue wakeups, to match Linux PTY semantics. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12914 from tanyifeng:pty-tcsbrk-tcflsh e00ca0a PiperOrigin-RevId: 897772400
maci0
pushed a commit
to maci0/gvisor
that referenced
this pull request
Apr 23, 2026
PiperOrigin-RevId: 897823897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux PTYs accept TCSBRK as a no-op and implement TCFLSH by flushing the input and/or output queues. gVisor returned ENOTTY, which breaks programs such as pyserial during terminal setup.
Handle TCSBRK in the PTY ioctl paths and route TCFLSH through lineDiscipline.tcFlush(), including packet mode flush notification and queue wakeups, to match Linux PTY semantics.