runsc/cgroup: fix systemd cpuset byte order#13299
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test/cl921523084
branch
2 times, most recently
from
de3e598 to
6952395
Compare
RangeToBits builds a cgroup v2 CPU or memory-node mask with big.Int, then passes big.Int.Bytes to systemd as AllowedCPUs/AllowedMemoryNodes. big.Int returns bytes in big-endian order, while systemd expects byte 0 to describe IDs 0-7, byte 1 to describe IDs 8-15, and so on. This reverses multi-byte masks when Docker/containerd asks runsc to create a systemd transient scope. For example, an OCI cpuset of "8,184" can be applied as CPUs "0,176". Reverse the generated byte slice before returning it and add a regression test that spans enough bytes to catch the lane reversal. Here are a couple of related issues that "tipped us off" to this being the problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076814 opencontainers/runc@77cae9a Assisted-by: OpenAI Codex Signed-off-by: Michael Galaxy <mrgalaxy@nvidia.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#13251 from mrgalaxy-source:mrgalaxy/endianfix a4f9ed0 PiperOrigin-RevId: 921523084
copybara-service
Bot
force-pushed
the
test/cl921523084
branch
from
6952395 to
565764b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runsc/cgroup: fix systemd cpuset byte order
RangeToBits builds a cgroup v2 CPU or memory-node mask with big.Int, then passes big.Int.Bytes to systemd as AllowedCPUs/AllowedMemoryNodes. big.Int returns bytes in big-endian order, while systemd expects byte 0 to describe IDs 0-7, byte 1 to describe IDs 8-15, and so on.
This reverses multi-byte masks when Docker/containerd asks runsc to create a systemd transient scope. For example, an OCI cpuset of "8,184" can be applied as CPUs "0,176".
Reverse the generated byte slice before returning it and add a regression test that spans enough bytes to catch the lane reversal.
Here are a couple of related issues that "tipped us off" to this being the problem:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076814
opencontainers/runc@77cae9a
Assisted-by: OpenAI Codex
Signed-off-by: Michael Galaxy mrgalaxy@nvidia.com
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13251 from mrgalaxy-source:mrgalaxy/endianfix a4f9ed0