Skip nvidia-cdi-hook's disable-device-node-modification hook.#13309
Merged
Conversation
Contributor
|
Thanks @ayushr2 🥇 |
copybara-service
Bot
force-pushed
the
test/cl922924116
branch
from
54851a7 to
3a2753e
Compare
The hook effectively overrides the `/proc/driver/nvidia/params` setting of `ModifyDeviceFiles: 1` to `0`. gVisor already emulates that hook in nvproxy.Register() by applying the same override to the virtualized `/proc/driver/nvidia/params` file exposed to the application. Fixes #13283 PiperOrigin-RevId: 922990855
copybara-service
Bot
force-pushed
the
test/cl922924116
branch
from
3a2753e to
8f3bcd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip nvidia-cdi-hook's disable-device-node-modification hook.
The hook effectively overrides the
/proc/driver/nvidia/paramssetting ofModifyDeviceFiles: 1to0. gVisor already emulates that hook innvproxy.Register() by applying the same override to the virtualized
/proc/driver/nvidia/paramsfile exposed to the application.Fixes #13283