Conversation
meeehow
reviewed
Nov 11, 2022
ZetaTwo
commented
Nov 11, 2022
meeehow
suggested changes
Nov 11, 2022
Contributor
meeehow
left a comment
meeehow
left a comment
There was a problem hiding this comment.
This looks good, thanks for implementing this! Can you take a look at my comments and also mention the new importer in readme file?
ZetaTwo
force-pushed
the
deb-importer
branch
from
db40d4f to
b860c44
Compare
Contributor
Author
|
I think I have addressed all the comments now. |
Contributor
Author
|
Nits fixed. |
Contributor
|
Thanks for implementing this importer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new importer that can import .deb packages. It uses
dpkg-debfor the actual unpacking so we might want to add that to the README as well. It is heavily based on the targz importer with very slight changes to use .deb files and dpkg-deb to unpack. The testdata is the same as targz testdata but repackaged as .deb packages.