Merged
Conversation
Contributor
ZetaTwo
commented
Nov 26, 2022
- Remove error return type from processingWorker as it is always nil and never checked.
- Use variable read from locked dict
- grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials()
- Check return value of io.Copy
- Rename importer template to stop treating it as Go code that's used
- Check return value of extractWimFolder()
- Use bytes.Equal(...) instead of bytes.Compare(...) == 0
meeehow
reviewed
Nov 29, 2022
meeehow
suggested changes
Nov 30, 2022
Contributor
meeehow
left a comment
There was a problem hiding this comment.
This looks good, just one small request, take a look at my last comment
meeehow
approved these changes
Nov 30, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.