Skip to content

Address various linting issues#29

Merged
meeehow merged 2 commits intogoogle:mainfrom
ZetaTwo:lint
Nov 30, 2022
Merged

Address various linting issues#29
meeehow merged 2 commits intogoogle:mainfrom
ZetaTwo:lint

Conversation

@ZetaTwo
Copy link
Contributor

@ZetaTwo ZetaTwo commented Nov 26, 2022

  • Remove error return type from processingWorker as it is always nil and never checked.
  • Use variable read from locked dict
  • grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials()
  • Check return value of io.Copy
  • Rename importer template to stop treating it as Go code that's used
  • Check return value of extractWimFolder()
  • Use bytes.Equal(...) instead of bytes.Compare(...) == 0

Copy link
Contributor

@meeehow meeehow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one small request, take a look at my last comment

@meeehow
Copy link
Contributor

meeehow commented Nov 30, 2022

Thanks!

@meeehow meeehow closed this Nov 30, 2022
@meeehow meeehow reopened this Nov 30, 2022
@meeehow meeehow merged commit 35b15e8 into google:main Nov 30, 2022
@ZetaTwo ZetaTwo deleted the lint branch November 30, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants