Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6a4db59 to
0f7b2bf
Compare
|
Hi @Hu6li, thank you for this pull request! Would it be possible to decouple the server code from the client code? What I mean is to keep all the code that the client uses in the "main" package, under /client |
|
Hi @meeehow sure this is possible. |
|
@Hu6li Yes, the idea would be to have the server and the client code independent of each other. IIUC for this PR there shouldn't be much too of code redundancy, you'd just need to create the cloudspanner and postgres clients (and potentially structs). |
meeehow
left a comment
There was a problem hiding this comment.
Looks good, could you just fix the issue below?
"don't use underscores in Go names; var file_output should be fileOutput"
This pull request addresses issue #27
Implementing a simple client for cloudspanner/postgres
Currently it is only possible to query and print samples formatted as json
This can of course be extended into a more powerful client.
Please let me know what you think