frontend: Emit ordered comparison predicates for floats#2246
Merged
copybara-service[bot] merged 1 commit intogoogle:mainfrom Sep 22, 2025
Merged
Conversation
Floating point comparison predicates in the arith dialect differ from integer ones. This inserts the ordered variants fixing erroneous outputs such as `arith.cmpf slt` -> `arith.cmpf olt`.
AlexanderViand
approved these changes
Sep 22, 2025
Collaborator
AlexanderViand
left a comment
AlexanderViand
left a comment
There was a problem hiding this comment.
Great catch! If you ran into this "in the wild", you probably have examples that triggered this? If yes, it'd be great if you could add one as a unit test :)
j2kun
added
the
pull_ready
j2kun
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating point comparison predicates in the arith dialect differ from integer ones. This inserts the ordered variants fixing erroneous outputs such as
arith.cmpf slt->arith.cmpf olt.This is another issue I had while experimenting with the Python frontend and here I'm a bit more confident that this is indeed a bug.