Skip to content

Disable mdformat for good#2324

Merged
copybara-service[bot] merged 1 commit intogoogle:mainfrom
j2kun:fix-frontmatter
Oct 17, 2025
Merged

Disable mdformat for good#2324
copybara-service[bot] merged 1 commit intogoogle:mainfrom
j2kun:fix-frontmatter

Conversation

@j2kun
Copy link
Collaborator

@j2kun j2kun commented Oct 17, 2025

Sigh. Why can't google's internal markdown formatter work.

Edit: this PR includes a fix to a broken yaml frontmatter, and also adds a script that ensures google's internal fork of mdformat is disabled for all markdown files. This script is added as a pre-commit hook.

@j2kun j2kun requested a review from asraa October 17, 2025 05:37
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Oct 17, 2025
@j2kun
Copy link
Collaborator Author

j2kun commented Oct 17, 2025

Ugh copybara is apparently running mdformat now on all our docs. Time to destroy it.

@j2kun j2kun changed the title fix frontmatter mangled by google internal markdown formatter Disable mdformat for good Oct 17, 2025
@j2kun
Copy link
Collaborator Author

j2kun commented Oct 17, 2025

gahhhh now the comment is breaking the yaml frontmatter

@j2kun
Copy link
Collaborator Author

j2kun commented Oct 17, 2025

ok should be fixed now.

@copybara-service copybara-service bot merged commit 690a36f into google:main Oct 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants