range analysis: propagate state on plaintexts operations#2584
Merged
Conversation
copybara-service
bot
force-pushed
the
test_862194691
branch
2 times, most recently
from
f823e6e to
4f9ffc5
Compare
PiperOrigin-RevId: 862408126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
range analysis: propagate state on plaintexts operations
After an integrate update, llvm/llvm-project@35e9540 the lattigo dot_product_8f case started failing since GenerateParamCKKS would fail to generate parameters. This was happening because RangeAnalysis was not getting an initialized range value on the resulting value. The upstream commit made it so that the data flow analysis propagates values from the body region instead of falling back to a default (setToEntryState). Then, unitialized values were propagated in the IR.
I noticed that the values after scf.for weren't propagated, and those loops were found in the encrypt client helpers which are all plaintext values. Those were hitting default operation visiting cases, and so this fix handles that part of the code better by propgating plaintext states as well.
Now operations like remsi/index_cast are propagating instead of returning early - so now the iter_arg values are initialized properly.