Feature/heir cross integration#2946
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Let's leave out the MODULE.bazel.lock change. I think you can add it to .git/info/exclude to exclude it from your local git.
There was a problem hiding this comment.
Remove this file. It should not be needed anymore now that we have MODULE.bazel
| LogicalResult MulOp::verify() { | ||
| // Types (ciphertext,ciphertext)->ciphertext are already enforced by TableGen. | ||
| return success(); | ||
| } | ||
|
|
||
| LogicalResult RotOp::verify() { | ||
| // 'index' is an i64 attr enforced by Td | ||
| return success(); | ||
| } | ||
|
|
There was a problem hiding this comment.
You should not need these, and you can remove the corresponding hasVerifier from the ops tablegen.
cf9b9f8 to
46222c8
Compare
46222c8 to
d346aa2
Compare
|
@Zohaib58 I think there are still some issues with the rebase. One thing you could try is, from a fresh branch rebased over main, run |
d346aa2 to
f0069ef
Compare
Hi Jeremy, The current PR is missing LWEToJaxiteWord pass. Should I make another commit including that pass? Is there any issue with the LWEToJaxiteWord pass that I need to fix? |
|
I think I just missed LWEToJaxiteWord in my initial work. Let's put it into a separate PR. |
Would you prefer I wait until PR #2946 merges and then open the conversion pass against main, or is it OK to open a separate PR now (stacked on top of this branch / or rebased once this lands)? |
|
Generally OK to add additional stacked PRs. Keeping the individual PRs smaller makes it easier for me to review them. |
Adds end-to-end support for lowering JaxiteWord IR to CROSS (Google’s CKKS backend for TPU), including dialect ops, a crypto-context setup pass, and an expanded Python emitter.
This completes the JaxiteWord → CROSS path that was started in earlier JaxiteWord work. The LWE → JaxiteWord conversion pass is intentionally out of scope here and tracked separately in #2964.
Changes
JaxiteWord dialect
jaxiteword-configure-crypto-context pass