Added PositiveInfOrHighestValue and NegativeInfOrLowestValue#2446
Merged
copybara-service[bot] merged 2 commits intogoogle:masterfrom Jan 22, 2025
Merged
Added PositiveInfOrHighestValue and NegativeInfOrLowestValue#2446copybara-service[bot] merged 2 commits intogoogle:masterfrom
copybara-service[bot] merged 2 commits intogoogle:masterfrom
Conversation
jan-wassenberg
previously approved these changes
Jan 21, 2025
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Nice improvement, thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
hwy::PositiveInfOrHighestValue<T>(), which returns positive infinity ifTis a floating point type orhwy::HighestValue<T>()ifTis an integer type.Also added
hwy::NegativeInfOrLowestValue<T>()which returns negative infinity ifTis a floating point type orhwy::HighestValue<T>()ifTis an integer type.Also updated EMU128 ReduceMin/ReduceMax to use
hwy::PositiveInfOrHighestValue<T>()andhwy::NegativeInfOrLowestValue<T>().