Skip to content

Comments

Increase text contrast#2655

Merged
yschimke merged 2 commits intogoogle:mainfrom
ithinkihaveacat:improve-contrast2
Jul 18, 2025
Merged

Increase text contrast#2655
yschimke merged 2 commits intogoogle:mainfrom
ithinkihaveacat:improve-contrast2

Conversation

@ithinkihaveacat
Copy link
Contributor

@ithinkihaveacat ithinkihaveacat commented Jul 14, 2025

WHAT

Increase the contrast of the "sign-in" button.

WHY

Before:

image

After:

image

HOW

Explicitly specify secondaryChipColors(). Might also be a good idea to convert the Chip() to ActionSetting() for consistency too but going with the less invasive change.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Copy link
Collaborator

Run './gradlew :media:sample:spotlessApply' to fix these violations.

@ithinkihaveacat ithinkihaveacat marked this pull request as ready for review July 15, 2025 14:18
@yschimke yschimke merged commit 27c1259 into google:main Jul 18, 2025
6 checks passed
@ithinkihaveacat ithinkihaveacat deleted the improve-contrast2 branch July 18, 2025 11:38
kul3r4 pushed a commit to kul3r4/horologist-1 that referenced this pull request Sep 19, 2025
* Increase text contrast

* spotlessApply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants