Cleanup the coroutines code in CaptureComposable.kt#2676
Merged
yschimke merged 7 commits intogoogle:mainfrom Aug 15, 2025
Merged
Cleanup the coroutines code in CaptureComposable.kt#2676yschimke merged 7 commits intogoogle:mainfrom
yschimke merged 7 commits intogoogle:mainfrom
Conversation
luizgrp
approved these changes
Aug 15, 2025
| content() | ||
| } | ||
| } | ||
| coroutineScope.launch { |
Member
There was a problem hiding this comment.
I think this can get called more than once but subsequent calls to Deferred.complete have no effect.
Maybe instead of making assumptions of the implementation of onResult callback here, the instance of Deferred could be passed. Not a big deal for me.
castedmo
reviewed
Aug 15, 2025
| ) | ||
| ) ?: return null | ||
|
|
||
| val result = callback(virtualDisplay!!.display) |
Collaborator
There was a problem hiding this comment.
!! is now redundant here I guess.
kul3r4
pushed a commit
to kul3r4/horologist-1
that referenced
this pull request
Sep 19, 2025
* Cleanup the coroutines code in CaptureComposable.kt --------- Co-authored-by: yschimke <231923+yschimke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Split out functions to separate layers of abstraction (Compose, Coroutines, Normal).
WHY
Got some warnings about mixing suspend and non suspend methods. False alarm due to nesting, but removing that confusion seems worthwhile.
HOW
Checklist 📋