Skip to content

Comments

Handle other dispatchers#2682

Merged
yschimke merged 2 commits intogoogle:mainfrom
yschimke:fix_image
Aug 20, 2025
Merged

Handle other dispatchers#2682
yschimke merged 2 commits intogoogle:mainfrom
yschimke:fix_image

Conversation

@yschimke
Copy link
Collaborator

WHAT

Handle other dispatchers

WHY

May run on a background thread, so switch back to Main as needed.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from castedmo August 19, 2025 18:49
}
}
return bitmap
return bitmap?.asAndroidBitmap()?.copy(Bitmap.Config.ARGB_8888, false)?.asImageBitmap()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the copy necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it's problematic, failing with a hardware error.

I'll follow up with a param to resolve this.

@yschimke yschimke merged commit f62d002 into google:main Aug 20, 2025
6 checks passed
kul3r4 pushed a commit to kul3r4/horologist-1 that referenced this pull request Sep 19, 2025
* Handle other dispatchers
* convert hardware to software bitmaps
* add another resource factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants