Skip to content

Be consistent about converting status to error message #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 21, 2026
Merged

Be consistent about converting status to error message #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/brush_behavior_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ int64_t BrushBehaviorNative_createFromOrderedNodes(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeBrushBehavior(std::move(brush_behavior));
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/brush_behavior_node_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ int64_t ValidateAndHoistNode(void* jni_env_pass_through,
if (absl::Status status = ValidateBrushBehaviorNode(node); !status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeBrushBehaviorNode(std::move(node));
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/brush_family_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ int64_t BrushFamilyNative_create(
if (!brush_family.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(brush_family.status().code()),
brush_family.status().message().data());
brush_family.status().ToString().c_str());
return 0;
}

Expand Down
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/brush_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ int64_t BrushNative_create(
if (!brush.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(brush.status().code()),
brush.status().message().data());
brush.status().ToString().c_str());
return 0;
}

Expand Down
8 changes: 4 additions & 4 deletions ink/brush/internal/jni/brush_paint_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ int64_t ValidateAndHoistColorFunctionOrThrow(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeColorFunction(std::move(color_function));
Expand Down Expand Up @@ -122,7 +122,7 @@ int64_t BrushPaintNative_create(
if (absl::Status status = ValidateBrushPaint(brush_paint); !status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeBrushPaint(std::move(brush_paint));
Expand Down Expand Up @@ -199,7 +199,7 @@ int64_t TilingTextureNative_create(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeTextureLayer(std::move(texture_layer));
Expand All @@ -222,7 +222,7 @@ int64_t StampingTextureNative_create(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeTextureLayer(std::move(texture_layer));
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/brush_tip_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ int64_t BrushTipNative_create(
if (absl::Status status = ValidateBrushTip(tip); !status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeBrushTip(std::move(tip));
Expand Down
2 changes: 1 addition & 1 deletion ink/brush/internal/jni/easing_function_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ int64_t ValidateAndHoistEasingFunction(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return 0;
}
return NewNativeEasingFunction(std::move(easing_function));
Expand Down
4 changes: 2 additions & 2 deletions ink/strokes/internal/jni/stroke_input_batch_native.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ bool MutableStrokeInputBatchNative_appendSingle(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return false;
}
return true;
Expand All @@ -136,7 +136,7 @@ bool MutableStrokeInputBatchNative_appendBatch(
!status.ok()) {
throw_from_status_callback(jni_env_pass_through,
static_cast<int>(status.code()),
status.message().data());
status.ToString().c_str());
return false;
}
return true;
Expand Down
Loading