Fix several paths following samples/ and runtime/ code moves. - #8987
Merged
Conversation
More to come as more code moves around.
This will keep changing for some time.
ScottTodd
marked this pull request as ready for review
April 25, 2022 23:00
ScottTodd
requested review from
stellaraccident
and removed request for
GMNGeoffrey
April 25, 2022 23:00
antiagainst
approved these changes
Apr 26, 2022
stellaraccident
approved these changes
Apr 26, 2022
stellaraccident
left a comment
stellaraccident
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Many of these were opaque to me/ci and are good to know about and fix.
ScottTodd
added a commit
that referenced
this pull request
Apr 27, 2022
Missed this in #8988 (and only tested the Buildkite pipeline on #8987) Should fix https://buildkite.com/iree/iree-samples/builds/321#645def5a-0354-4b8c-bfb4-a2a3985e9e54 ``` [2022-04-27T00:05:04Z] python3: can't open file './colab/test_notebooks.py': [Errno 2] No such file or directory ```
mariecwhite
pushed a commit
to mariecwhite/iree
that referenced
this pull request
May 6, 2022
…rg#8987) Following iree-org#8950 and iree-org#8958. Probably more to come with iree-org#8955. This should fix the failing builds on https://buildkite.com/iree/iree-build-configurations and https://buildkite.com/iree/iree-samples.
mariecwhite
pushed a commit
to mariecwhite/iree
that referenced
this pull request
May 6, 2022
Missed this in iree-org#8988 (and only tested the Buildkite pipeline on iree-org#8987) Should fix https://buildkite.com/iree/iree-samples/builds/321#645def5a-0354-4b8c-bfb4-a2a3985e9e54 ``` [2022-04-27T00:05:04Z] python3: can't open file './colab/test_notebooks.py': [Errno 2] No such file or directory ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #8950 and #8958. Probably more to follow with #8955.
This should fix the failing builds on https://buildkite.com/iree/iree-build-configurations and https://buildkite.com/iree/iree-samples.