Use id<MyJavaInterface> instead of MyJavaInterface * in ObjectiveCKmpMethod#2747
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_914248968
branch
2 times, most recently
from
effc8e1 to
0ef8b85
Compare
…CKmpMethod Map java interfaces (translated to ObjC protocols) to `id<MyJavaInterface>` rather than `MyJavaInterface *`, which is incorrect in ObjC. Types that are specifically mapped, such as `java.util.List`, are not affected. PiperOrigin-RevId: 917081023
copybara-service
Bot
force-pushed
the
test_914248968
branch
from
0ef8b85 to
d23edce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
id<MyJavaInterface>instead ofMyJavaInterface *in ObjectiveCKmpMethodMap java interfaces (translated to ObjC protocols) to
id<MyJavaInterface>rather thanMyJavaInterface *, which is incorrect in ObjC. Types that are specifically mapped, such asjava.util.List, are not affected.