Replace modifier size to height, improving code readability.#367
Merged
temcguir merged 5 commits intogoogle:mainfrom Jul 10, 2025
Merged
Replace modifier size to height, improving code readability.#367temcguir merged 5 commits intogoogle:mainfrom
size to height, improving code readability.#367temcguir merged 5 commits intogoogle:mainfrom
Conversation
Jaehwa-Noh
changed the title
size to height, improving code readability.
temcguir
reviewed
Jul 3, 2025
Collaborator
temcguir
left a comment
temcguir
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
temcguir
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
sizemodifier was added in #335.Actually, the width is controlled by an
RowScope().weight(1f)modifier, so thatsizemodifier doesn't make a width change.That was reason, I replaced the
sizemodifier toheight.