More fuzz fixes #27
Merged
More fuzz fixes #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richkadel
force-pushed
the
more-fuzz-fixes
branch
from
52adb90 to
c5ab618
Compare
richkadel
force-pushed
the
more-fuzz-fixes
branch
from
c5ab618 to
57cbd9e
Compare
Contributor
Author
|
CIFuzz highlighted some issues. I downloaded the corpus used by CIFuzz (over 4000 input files) and fixed one of the most obvious issues (misaligned byte indexes slicing unicode strings in the new error formatting code), but there is still a logic bug in here somewhere. So I marked this draft will I look into it. |
richkadel
force-pushed
the
more-fuzz-fixes
branch
4 times, most recently
from
9833b29 to
550cc3f
Compare
Contributor
Author
|
@erickt - No rush of course! Have a great holiday break. This is ready for review now. |
This PR addresses two more classes of oss-fuzz failures. 1. A document with many open braces, without closing braces, can eventually cause program stack overflow. I've added function variations to set a specific limit, and the existing functions set this value to a default limit. 2. A document that ends with an extra closing brace could crash the parser. This is now caught, and a parser error is emitted. This may have also contributed to an "out-of-memory" error, as the reproducer test (included with this PR) no longer fails. I also added better testing support for debugging the parser on sample documents (such as oss-fuzz reproducers). Fixes: google#22 Fixes: google#23 Fixes: google#24
richkadel
force-pushed
the
more-fuzz-fixes
branch
from
550cc3f to
e86fecb
Compare
erickt
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit nesting to prevent program stack overflow, and catch bad brace
This PR addresses two more classes of oss-fuzz failures.
A document with many open braces, without closing braces, can
eventually cause program stack overflow. I've added function variations
to set a specific limit, and the existing functions set this value to a
default limit.
A document that ends with an extra closing brace could crash the
parser. This is now caught, and a parser error is emitted. This may have
also contributed to an "out-of-memory" error, as the reproducer test
(included with this PR) no longer fails.
I also added better testing support for debugging the parser on sample
documents (such as oss-fuzz reproducers).
Fixes: #22
Fixes: #23
Fixes: #24