Merged
Conversation
libjsonnet_test_snippet was strange, because it _defined_ three native functions (that can be used with `std.native`), but it didn't actually try using them, and it took an input snippet on the command line so a critical part of the test came from the test harness (tests.sh). The replacement is self-contained. It doesn't use GoogleTest because it's written in plain C, not C++. Other than that, it works like any other test executable, running a few separate tests and reporting the results. tests.sh is updated accordingly The Makefile is updated also. The CMakeLists.txt is updated to also run this test with CTest. The core/BUILD file is updated to add this as a Bazel test.
Normalize test naming to end with _test instead of having it in the middle.
The tests that it runs are directly run by the root tests.sh anyway.
Normalize test naming to end with _test instead of having it in the middle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to clean up the test infrastructure in little steps.
_test(instead of havingtestsomewhere in the middle)std.assertEqualsexpression). This is renamed and updated to explicitly test the native callback facility and not take any command line arguments.