feat: Make skip_lines option allow skipping at end#122
Merged
JeffFaer merged 9 commits intogoogle:mainfrom Mar 18, 2026
Merged
Conversation
skip_lines now interprets negative values as lines to skip at the end of a sorted region. skip_lines now accepts up to two values. If two values are specified, the first must be lines skipped at the start and the second lines skipped at the end. Internally this is represented as an int slice. Add ability for parse options to handle int slices. Modify golden examples to maintain intended behavior. Update documentation with example of skipping lines both at the start and end.
willbeason
changed the title
JeffFaer
reviewed
Mar 16, 2026
Co-authored-by: Jeffrey Faer <jeffrey.faer@gmail.com>
Co-authored-by: Jeffrey Faer <jeffrey.faer@gmail.com>
Per review comments, allow start/end offsets to be in any order.
JeffFaer
approved these changes
Mar 17, 2026
Co-authored-by: Jeffrey Faer <jeffrey.faer@gmail.com>
Co-authored-by: Jeffrey Faer <jeffrey.faer@gmail.com>
Per discussion, make error more explicit about what needs to be changed and what it means. Preferably users should be able to read the error message and correct things without having to refer to the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds feature discussed in #80
skip_lines now interprets negative values as lines to skip at the end of a sorted region.
skip_lines now accepts up to two values. If two values are specified, the first must be lines skipped at the start and the second lines skipped at the end. Internally this is represented as an int slice.
Add ability for parse options to handle int slices.
Modify golden examples to maintain intended behavior.
Update documentation with example of skipping lines both at the start and end.