This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Conversation
gdbelvin
approved these changes
Aug 23, 2018
Contributor
gdbelvin
left a comment
gdbelvin
left a comment
There was a problem hiding this comment.
I went back and forth on whether the VRF deserves it's own test data, but this is probably fine for now. If we wanted to get this VRF incorporated into golang/x/crypto, we'd need to change this.
Please provide a detailed PR description, and ensure Travis passes.
| @@ -179,40 +186,37 @@ func TestVRF(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestProofToHash(t *testing.T) { | |||
Contributor
There was a problem hiding this comment.
Please add a note about how to regenerate the test data.
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
=======================================
Coverage 66.01% 66.01%
=======================================
Files 39 39
Lines 2742 2742
=======================================
Hits 1810 1810
Misses 613 613
Partials 319 319Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes VRF verification tests to use common generated testdata. This makes it easier for other projects that want to implement VRF verification to keep up-to-date with keytransparency's VRF implementation by using the same testdata.