Add negative tests for all meta-use-site target#2911
Merged
Conversation
This was referenced May 1, 2026
all meta-use-site target
1847c6e to
04b5319
Compare
Collaborator
Author
|
Btw, since this PR was opened, a code/execution path that previously threw an exception has been fixed with a proper implementation on |
troelsbjerre
previously approved these changes
May 4, 2026
The merge-base changed after approval.
04b5319 to
631dee3
Compare
Collaborator
Author
|
Rebased on main |
troelsbjerre
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2915
This PR adds the following:
Adds a failing test for invalid use of the
alluse-site target on grouped annotations (see KEEP 402)Adds a
runFailingTestfunction toAbstractKSPTestthat asserts the expected output does not match the actual outputAdds a
runThrowingTestfunction toAbstractKSPTestthat asserts the test throws anInternalKSPException. This can be expanded to assert other types of exceptions, but for now the idea is that it forces throwing expressions to useInternalKSPExceptionwhich provides an error message with a bit more information than what one might provide witherrororrequire.Refactor
runTest,runFailingTest,runThrowingTestto reuse test setup code.