Skip to content

Rework Python binding #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asoulier merged 2 commits into from
Dec 17, 2024
Merged

Rework Python binding #61

asoulier merged 2 commits into from
Dec 17, 2024

Conversation

@zxzxwu
Copy link
Contributor

@zxzxwu zxzxwu commented Dec 11, 2024 •
edited
Loading

  • Add pytests
  • Rename arguments to make them more clear
  • Add type annotations
  • Black reformat

@zxzxwu zxzxwu marked this pull request as draft December 11, 2024 13:31
@zxzxwu zxzxwu marked this pull request as ready for review December 11, 2024 14:18
@zxzxwu zxzxwu changed the title [WIP] Rework Python binding Rework Python binding Dec 11, 2024
@zxzxwu zxzxwu mentioned this pull request Dec 11, 2024
Merged
@zxzxwu
Copy link
Contributor Author

zxzxwu commented Dec 16, 2024

Hi @asoulier, could you help review this PR? Thanks.

asoulier
asoulier reviewed Dec 16, 2024
View reviewed changes
@asoulier asoulier merged commit 0b28bf2 into google:main Dec 17, 2024
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asoulier asoulier asoulier left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxzxwu @asoulier