python: remove dependency to python-dotenv#1285
Merged
Conversation
This also avoids loading .env, which may surprise some users. Only the magika_client.py was using the environment to override the default model used, so I don't expect this to create backward compatibility problems. Fixes #1283.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the python-dotenv dependency, which is a good improvement as it avoids automatically loading .env files and surprising users of the library. The changes are consistent across the pyproject.toml, the source code where the dependency was used, and the uv.lock file. The CHANGELOG.md has also been updated to reflect this change and correctly notes that .env files are no longer loaded automatically. The changes are correct and improve the library's design by removing side effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also avoids loading .env, which may surprise some users. Only the magika_client.py was using the environment to override the default model used, so I don't expect this to create backward compatibility problems.
Fixes #1283.