Merged
Conversation
afourney
reviewed
Mar 12, 2025
afourney
left a comment
afourney
left a comment
There was a problem hiding this comment.
I've reviewed the implementation, and I love the care to detail on common errors etc. I've not had a chance to test this yet, but will ASAP. I look forward to this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
identify_streamAPI, as suggested in #970. With this API, one can identify the content type of an already-open stream; the implementation does not read the full file, and it justseek()s around. This new API avoids clients to be forced to (directly or indirectly) read the full file's content in memory.Fixes #970.