-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Description
Trying to run make lint in the software directory successfully runs isort and black but flake8 fails. That check should be fixed or disabled.
cd software
make venv # TODO: further testing to understand if this is required on initial checkout
make setup
make lint
Expected: 3 tools run
Actual:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/__main__.py", line 4, in <module>
cli.main()
~~~~~~~~^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/main/cli.py", line 22, in main
app.run(argv)
~~~~~~~^^^^^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/main/application.py", line 363, in run
self._run(argv)
~~~~~~~~~^^^^^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/main/application.py", line 350, in _run
self.initialize(argv)
~~~~~~~~~~~~~~~^^^^^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/main/application.py", line 330, in initialize
self.find_plugins(config_finder)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/main/application.py", line 153, in find_plugins
self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/plugins/manager.py", line 356, in __init__
self.manager = PluginManager(
~~~~~~~~~~~~~^
self.namespace, local_plugins=local_plugins
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/plugins/manager.py", line 238, in __init__
self._load_entrypoint_plugins()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/local/google/home/brianbeck/makerspace-auth/software/.venv/lib/python3.13/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
eps = importlib_metadata.entry_points().get(self.namespace, ())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'
make: *** [Makefile:44: lint] Error 1
Potentially relevant SO post: https://stackoverflow.com/questions/75591296/entrypoints-object-has-no-attribute-get-during-running-pre-commit
For anyone wondering what the exact change has been that fixed it and doesn't want to diff the OP's config against this new config like I did: rev: 3.9.2 of flake8 was changed to rev: 5.0.4 ;
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels