Skip to content

Accept proxy as optional arg in the constructor and replace hardcoded values #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Accept proxy as optional arg in the constructor and replace hardcoded values #178

wants to merge 2 commits into from

Conversation

@zion-off
Copy link

@zion-off zion-off commented Sep 5, 2025

Closes #177

  • Users can now use a proxy by setting the SOAR_PROXY environment variable

@zion-off zion-off requested a review from a team September 5, 2025 00:40
@Jb799 Jb799 mentioned this pull request Nov 4, 2025
Open
@Jb799
Copy link

Jb799 commented Nov 4, 2025

Hello,

Why not using the trust_env parameter like this ?
aiohttp.ClientSession(trust_env=True)

I tried for the SOAR mcp server and It was working well for me.

Documentation about this parameter: HERE

Thank's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SOAR server needs some updates to support proxy

2 participants

@zion-off @Jb799