fix: Add setuptools package discovery configuration to pyproject.toml #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the `pyproject.toml` to explicitly configure how setuptools finds packages to include in the distribution. By adding the `[tool.setuptools.packages.find]` section, we ensure that all sub-packages under `secops_mcp` are automatically and correctly included when the project is built. This prevents potential `ModuleNotFoundError` issues for consumers of the package. The package version has been bumped to 0.4.1 to release this fix.
mihirvala08
approved these changes
Oct 7, 2025
Collaborator
mihirvala08
left a comment
mihirvala08
left a comment
There was a problem hiding this comment.
Verified with build wheel file uvx --from google_secops_mcp-0.4.1-py3-none-any.whl secops_mcp and also from server root uvx --from . secops_mcp
Thank you for this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ModuleNotFoundError when running
uvx --from google-secops-mcp secops_mcpby adding proper package discovery configuration to pyproject.toml.Problem
When installing the package from PyPI, setuptools didn't know to include the
secops_mcppackage directory because the pyproject.toml was missing package discovery configuration. This caused:Solution
Added
[tool.setuptools.packages.find]section to pyproject.toml to explicitly tell setuptools to include thesecops_mcppackage and its subpackages.Test Plan
python -m buildsecops_mcpdirectory is included in the wheeluvx --from . secops_mcp --helpsuccessfullyChanges