Skip to content

Conversation

@boomanaiden154
Copy link
Collaborator

@boomanaiden154 boomanaiden154 commented Apr 3, 2025

This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

This is intended to be used before training. After compiling a corpus
with compile_corpus.py, functions that change during regalloc (and thus
show up as keys when generating a default trace) can then be extracted
into a separate corpus for use during the training process, assuming
serialized basic blocks are available for functions that do not get
extracted.

@boomanaiden154 boomanaiden154 requested a review from mtrofin April 3, 2025 06:54
boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

Pull Request: google#487
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

Pull Request: google#487
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

Pull Request: google#487
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

Pull Request: google#487
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
@mtrofin
Copy link
Collaborator

mtrofin commented Apr 3, 2025

elaborate the scenario - why and when is this tool useful?

boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

Pull Request: google#487
@boomanaiden154
Copy link
Collaborator Author

elaborate the scenario - why and when is this tool useful?

Added to the PR description.

Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
boomanaiden154 added a commit to boomanaiden154/ml-compiler-opt that referenced this pull request Apr 3, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

This is intended to be used before training. After compiling a corpus
with compile_corpus.py, functions that change during regalloc (and thus
show up as keys when generating a default trace) can then be extracted
into a separate corpus for use during the training process, assuming
serialized basic blocks are available for functions that do not get
extracted.

Pull Request: google#487
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
@boomanaiden154 boomanaiden154 changed the base branch from spr/boomanaiden154/main.add-extract_functions-script to main April 3, 2025 20:40
@boomanaiden154 boomanaiden154 merged commit 14860b1 into main Apr 3, 2025
25 checks passed
@boomanaiden154 boomanaiden154 deleted the spr/boomanaiden154/add-extract_functions-script branch April 3, 2025 20:40
svkeerthy pushed a commit that referenced this pull request Apr 10, 2025
This just parses some flag values and passes them along to
extract_functions_lib so that the relevant functionality can actually be
invoked from the command line.

This is intended to be used before training. After compiling a corpus
with compile_corpus.py, functions that change during regalloc (and thus
show up as keys when generating a default trace) can then be extracted
into a separate corpus for use during the training process, assuming
serialized basic blocks are available for functions that do not get
extracted.

Reviewers: mtrofin

Reviewed By: mtrofin

Pull Request: #487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants