Skip to content

refactor: Move C++ tests to tests/ directory#33

Merged
Leahlijuan merged 10 commits intomainfrom
chore/move-cpp-tests
Feb 5, 2026
Merged

refactor: Move C++ tests to tests/ directory#33
Leahlijuan merged 10 commits intomainfrom
chore/move-cpp-tests

Conversation

@Leahlijuan
Copy link
Collaborator

@Leahlijuan Leahlijuan commented Feb 5, 2026

Fixes #31

Reasons for the movement:

  • Cleaner Source Tree: Keeps src/ focused strictly on production code.

  • Unified Structure: Consolidates all tests (Python and C++) into a single top-level tests/ directory.

  • Easier Packaging: Prevents test files from accidental inclusion in production builds.

  • Simplified Tooling: Makes configured excludes (e.g., for coverage or linters) simpler and less error-prone.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Leahlijuan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's C++ test infrastructure by consolidating all test files into a top-level tests/ directory. This change aims to improve project organization, making it easier to locate and manage test suites independently from the main source code, and updates the CMake build configurations accordingly.

Highlights

  • Test File Relocation: C++ test files have been moved from their original src/.../test/ locations to a new, centralized tests/ directory at the project root. This change affects numerous test files across different modules.
  • CMake Build System Updates: CMakeLists.txt files within the affected modules have been updated to reflect the new paths for the relocated test source files, ensuring the build system correctly finds and compiles them.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/ml_flashpoint/checkpoint_object_manager/buffer_object/CMakeLists.txt
    • Updated paths for buffer_object_test.cpp and buffer_helper_test.cpp to reference their new location under tests/.
  • src/ml_flashpoint/checkpoint_object_manager/buffer_object/test/buffer_helper_test.cpp
    • File renamed and moved to tests/checkpoint_object_manager/buffer_object/test/buffer_helper_test.cpp.
  • src/ml_flashpoint/checkpoint_object_manager/buffer_object/test/buffer_object_test.cpp
    • File renamed and moved to tests/checkpoint_object_manager/buffer_object/test/buffer_object_test.cpp.
  • src/ml_flashpoint/checkpoint_object_manager/object_manager/CMakeLists.txt
    • Updated path for object_manager_test.cpp to reference its new location under tests/.
  • src/ml_flashpoint/checkpoint_object_manager/object_manager/test/object_manager_test.cpp
    • File renamed and moved to tests/checkpoint_object_manager/object_manager/test/object_manager_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/CMakeLists.txt
    • Updated paths for multiple test files (e.g., protocol_test.cpp, transfer_service_test.cpp) to reference their new location under tests/.
  • src/ml_flashpoint/replication/transfer_service/test/connection_pool_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/connection_pool_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/mlf_log_sink_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/mlf_log_sink_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/net_util_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/net_util_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/protocol_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/protocol_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/task_queue_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/task_queue_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/task_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/task_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/thread_pool_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/thread_pool_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/transfer_helpers_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/transfer_helpers_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/transfer_service_p2p_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/transfer_service_p2p_test.cpp.
  • src/ml_flashpoint/replication/transfer_service/test/transfer_service_test.cpp
    • File renamed and moved to tests/replication/transfer_service/test/transfer_service_test.cpp.
Activity
  • The pull request addresses and fixes issue Migrate all c++ tests to tests/ dir #31.
  • The author, Leahlijuan, initiated a significant refactoring to improve the project's test directory structure by moving C++ tests to a dedicated tests/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving C++ tests from within the src directory to a top-level tests directory. This is a good practice for separating test code from source code. The changes in the CMakeLists.txt files correctly update the paths to the test files. My review includes suggestions to further improve the maintainability of these build scripts by using variables for the common test source directory paths, which will make them cleaner and easier to manage in the future.

@Leahlijuan Leahlijuan requested review from g-husam and kkkapu February 5, 2026 15:51
@g-husam g-husam changed the title Refactor: Move C++ tests to tests/ directory refactor: Move C++ tests to tests/ directory Feb 5, 2026
@Leahlijuan Leahlijuan self-assigned this Feb 5, 2026
@Leahlijuan Leahlijuan requested a review from g-husam February 5, 2026 21:57
@google google deleted a comment from Leahlijuan Feb 5, 2026
@Leahlijuan Leahlijuan merged commit 22d8691 into main Feb 5, 2026
5 checks passed
@Leahlijuan Leahlijuan deleted the chore/move-cpp-tests branch February 5, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate all c++ tests to tests/ dir

2 participants