Skip to content

ci: re-enable clang-format check in build workflow#38

Merged
g-husam merged 2 commits intomainfrom
fix-clang
Feb 10, 2026
Merged

ci: re-enable clang-format check in build workflow#38
g-husam merged 2 commits intomainfrom
fix-clang

Conversation

@kkkapu
Copy link
Collaborator

@kkkapu kkkapu commented Feb 9, 2026

Fix clang-format in build #2

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@kkkapu kkkapu requested review from Leahlijuan and g-husam February 9, 2026 21:42
Comment on lines 110 to 112
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets also specify a particular version - clang-format-18, and use that below

Suggested change
sudo apt-get update && sudo apt-get install -y clang-format-18
clang-format-18 --version
find src -name '*.cpp' -o -name '*.h' | xargs clang-format-18 --dry-run --Werror

Let's also specify that in the README

Change-Id: I8ed3d4b44c398313a7b9abe8eebccafc95909737
Change-Id: I3c8af4e2a74a5dd211d8ba1f0b52fbd67554c7dc
@g-husam g-husam enabled auto-merge (squash) February 10, 2026 01:18
@g-husam g-husam merged commit 182922f into main Feb 10, 2026
5 checks passed
@g-husam g-husam deleted the fix-clang branch February 10, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants