feat: add env_str to snippet_client_v2.Config to allow am instrument command prefix (fixes #1004)#1008
Open
devimano2011 wants to merge 1 commit intogoogle:masterfrom
Conversation
fixes google#1004) Add optional environment variable string to launch command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004
Problem
Users who need to prepend environment variables or command wrappers (e.g.
ENV_VAR=valueor a wrapper command) to theam instrumentcommand insnippet_client_v2had no way to do so.Solution
Add an
env_strfield tosnippet_client_v2.Configthat, when set, is prepended to theam instrumentcommand. This allows users to:config.env_str = 'MY_VAR=value'config.env_str = 'wrapper_cmd'Changes
env_str: str = ''field to theConfigdataclass with documentation_LAUNCH_CMDtemplate to support{env_str}prefixenv_strvalue when building the launch command in_start_server()Usage