-
Notifications
You must be signed in to change notification settings - Fork 205
Rename test_bed_name to testbed_name. #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xpconanfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia)
mobly/base_test.py, line 76 at r1 (raw file):
log_path: string, specifies the root directory for all logs written by a test run. testbed_name: string, the name of the test bed used by a test run.
you shouldn't directly rename a public attribute.
follow the standard SW release practice.
Add the new name, mark the old name deprecated (not removal), and wait for the next major version bump to remove the deprecated one.
See my recent PR to remove deprecated APIs.
xianyuanjia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia and @xpconanfan)
mobly/base_test.py, line 76 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
you shouldn't directly rename a public attribute.
follow the standard SW release practice.Add the new name, mark the old name deprecated (not removal), and wait for the next major version bump to remove the deprecated one.
See my recent PR to remove deprecated APIs.
Done.
xpconanfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @xianyuanjia)
xpconanfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia)
mobly/config_parser.py, line 165 at r2 (raw file):
log_path: string, specifies the root directory for all logs written by a test run. testbed_name: string, the name of the test bed used by a test run.
this is also a public API, which cannot be simply renamed
xianyuanjia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia and @xpconanfan)
mobly/config_parser.py, line 165 at r2 (raw file):
Previously, xpconanfan (Ang Li) wrote…
this is also a public API, which cannot be simply renamed
Done.
xpconanfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia)
mobly/base_test.py, line 78 at r3 (raw file):
test_bed_name: [Deprecated, use 'testbed_name' instead] string, the name of the test bed used by a test run. testbed_name: string, the name of the test bed used by a test run.
do you think we should move testbed_name into current_test_info?
(or just remove it since i can't find any usage of it...)
xianyuanjia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @xianyuanjia and @xpconanfan)
mobly/base_test.py, line 78 at r3 (raw file):
Previously, xpconanfan (Ang Li) wrote…
do you think we should move
testbed_nameintocurrent_test_info?
(or just remove it since i can't find any usage of it...)
This is being used by certain power tests for logging purposes. I don't think this should be moved into current_test_info , since it is static and does not depend on the test case/stage being run.
xpconanfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @xianyuanjia)
This change is