Add open.py to open file after resolving symlink#1284
Merged
Conversation
When 'Mozc64.msi' is built with Bazel, it is placed under a symlinked directory, which 'msiexec.exe' does not recognize. To avoid this pitfall this commit introduces a helper script `open.py` to open the file after resolving symlink so that the real path can be passed to 'msiexec.exe'. python build_tools/open.py bazel-bin/win32/installer/Mozc64.msi With above the build instructions can be simplified as the readers can just copy and paste the commands to build the installer then install it. Closes google#1283.
Collaborator
Author
|
Squashed then rebased. |
Collaborator
|
We have merged your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
Mozc64.msiis built with Bazel, it is placed under a symlinked directory, whichmsiexec.exedoes not recognize. To avoid this pitfall this commit introduces a helper scriptopen.pyto open the file after resolving symlink so that the real path can be passed to 'msiexec.exe'.With above the build instructions can be simplified as the readers can just copy and paste the commands to build the installer then install it.
Closes #1283.
Issue IDs
Mozc64.msifrom terminal for Windows #1283Steps to test new behaviors (if any)
bazelisk build --config oss_windows --config release_build packagepython build_tools/open.py bazel-bin/win32/installer/Mozc64.msi