Build libmozc.so with 16 KB alignment#1363
Merged
Merged
Conversation
yukawa
force-pushed
the
android_16kb_alignment
branch
from
b29b7cd to
061d01e
Compare
While the document says that NDK version r28 and higher compile 16 KB-aligned by default [1], it seems that we still need to explicitly set linker options to ensure 16 KB alignment. Closes google#1364. [1]: https://developer.android.com/guide/practices/page-sizes
yukawa
force-pushed
the
android_16kb_alignment
branch
from
061d01e to
cc35113
Compare
Collaborator
|
We have merged your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While the document says that NDK version r28 and higher compile 16 KB-aligned by default, it seems that we still need to explicitly set linker options to ensure 16 KB alignment.
Closes #1364.
Issue IDs
libmozc.socompatible with 16 KB page sizes #1364Steps to test new behaviors (if any)
bazelisk build --config oss_android package --config release_buildunzip -p bazel-bin/android/jni/native_libs.zip libs/x86_64/libmozc.so | third_party/ndk/android-ndk-r28/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-objdump -p - | grep LOAD | awk '{ print $NF }' | head -1unzip -p bazel-bin/android/jni/native_libs.zip libs/arm64-v8a/libmozc.so | third_party/ndk/android-ndk-r28/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-objdump -p - | grep LOAD | awk '{ print $NF }' | head -12**14is shown at the both step 2 and step 3.