Remove Singleton from omaha_util_test.cc#1491
Merged
hiroyuki-komatsu merged 1 commit intoApr 28, 2026
Merged
Conversation
As part of our ongoing efforts to remove the dependency on Singleton, this commit rewrites omaha_util_test.cc without the Singleton class dependency. This is purely mechanical refactoring for unit testing, and there must be no observable behavioral change in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of our ongoing efforts to remove the dependency on
Singleton, this commit rewritesomaha_util_test.ccwithout theSingletonclass dependency.This is purely mechanical refactoring for unit testing, and there must be no observable behavioral change in production.
Issue IDs
N/A
Steps to test new behaviors (if any)
bazelisk test //win32/base:omaha_util_test