Work around QTBUG-145239 with a local patch#1506
Merged
Merged
Conversation
This commit implements a quick workaround for QTBUG-145239 [1], which causes build failure when building Qt 6.9.1 with XCode 26.4. Ideally we should switch to Qt 6.11.1 or lather that has the fix for QTBUG-145239 [2], but doing so requires us to bump the minimum supported OS version to macOS 13 (google#1458), which is also a non-trivial change. At the same time, macos-26 image in the GitHub Actions Runners GitHub is going to switch to XCode 26.4.1 in the week of May 11, 2026 [3]. We need some stopgap solution here. Let's patch the code in question locally in build_qt.py. Closes google#1455. [1]: https://qt-project.atlassian.net/browse/QTBUG-145239 [2]: https://codereview.qt-project.org/c/qt/qtbase/+/724619 [3]: actions/runner-images#14001
Collaborator
|
We have merged your PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit implements a quick workaround for QTBUG-145239, which causes build failure when building Qt 6.9.1 with XCode 26.4.
Ideally we should switch to Qt 6.11.1 or lather that has the fix for QTBUG-145239, but doing so requires us to bump the minimum supported OS version to macOS 13 (#1458), which is also a non-trivial change.
At the same time, macos-26 image in the GitHub Actions Runners GitHub is going to switch to XCode 26.4.1 in the week of May 11, 2026 (actions/runner-images#14001). We need some stopgap solution here.
Let's patch the code in question locally in
build_qt.py.Closes #1455.
Issue IDs
build_qt.pyfails with Xcode 26.4 on macOS #1455Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
python3 build_tools/build_qt.py --release --confirm_licensefinishes without any error