Fix DateTimeFormatsTest locale-dependent failures#98
Merged
fluentfuture merged 4 commits intogoogle:masterfrom Jan 22, 2026
Merged
Fix DateTimeFormatsTest locale-dependent failures#98fluentfuture merged 4 commits intogoogle:masterfrom
fluentfuture merged 4 commits intogoogle:masterfrom
Conversation
Tests were failing in non-US locales (GB, FR, etc.) due to: - AM/PM parsing differences (US: "AM" vs UK: "am") - Timezone abbreviation ambiguity (PST resolves differently) - Date formatting variations across locales Added JUnit @rule to ensure all tests run with US locale and UTC timezone. The rule saves the original locale/timezone before each test and restores them afterward in a finally block. This approach follows the standard JUnit TestRule pattern and ensures test isolation without affecting production code. Fixes google#93
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nickita-khylkouski
force-pushed
the
issue-93-locale-tests
branch
from
8284503 to
7d6dc1f
Compare
English text patterns (month names, weekday names, AM/PM) now explicitly use Locale.ENGLISH when creating DateTimeFormatter instances. This ensures consistent parsing behavior regardless of the JVM's default locale. Fixes google#99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing in non-US locales (GB, FR, etc.) due to AM/PM parsing differences and timezone abbreviation ambiguity.
Added JUnit @rule to ensure all tests run with US locale and UTC timezone. The rule saves the original locale/timezone before each test and restores them in a finally block.
This approach follows the standard JUnit TestRule pattern and ensures test isolation without affecting production code.
Fixes #93