Add missing ct keys#310
Merged
stapelberg merged 1 commit intogoogle:mainfrom Mar 26, 2025
Merged
Conversation
Contributor
Author
|
@stapelberg I am happy to add a full test in nftables_test.go if you want this merged.
Edit: Found the answer here |
The following keys were missing from the CtKey type: - `NFT_CT_SRC_IP` - `NFT_CT_DST_IP` - `NFT_CT_SRC_IP6` - `NFT_CT_DST_IP6` - `NFT_CT_ID` Since they also seem to be missing from the unix package, their actual values were added.
nickgarlis
force-pushed
the
add-missing-ct-keys
branch
from
e745822 to
85c93f1
Compare
stapelberg
approved these changes
Mar 26, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following keys were missing from the CtKey type:
NFT_CT_SRC_IPNFT_CT_DST_IPNFT_CT_SRC_IP6NFT_CT_DST_IP6NFT_CT_IDSince they also seem to be missing from the unix package, their actual values were added.