Skip to content

Update angular @21#2965

Merged
ptkach merged 1 commit intogoogle:masterfrom
ptkach:depsUpdate
Feb 24, 2026
Merged

Update angular @21#2965
ptkach merged 1 commit intogoogle:masterfrom
ptkach:depsUpdate

Conversation

@ptkach
Copy link
Collaborator

@ptkach ptkach commented Feb 20, 2026

Tested on alpha

This change is Reviewable

@ptkach ptkach requested a review from gbrodman February 20, 2026 18:10
@ptkach ptkach added the kokoro:force-run Force a Kokoro build. label Feb 20, 2026
@domain-registry-eng domain-registry-eng removed the kokoro:force-run Force a Kokoro build. label Feb 20, 2026
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 28 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ptkach).

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't tell what changed in the screenshots when looking at them in github, which means it lgtm

@gbrodman reviewed 19 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ptkach).

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ptkach).


console-webapp/dev-proxy.config.json line 4 at r3 (raw file):

  "/console-api":
  {
    "target": "http://[::1]:8080",

did you test this change with the local dev server? i remember this being finicky before


console-webapp/src/app/settings/security/security.component.spec.ts line 61 at r3 (raw file):

    }).compileComponents();

    // Update your saveSpy reference

what's this comment?

Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah new version of angular material, so might be some minor colors, borders, spacings differences here and there

@ptkach made 3 comments.
Reviewable status: 52 of 53 files reviewed, 2 unresolved discussions (waiting on gbrodman).


console-webapp/dev-proxy.config.json line 4 at r3 (raw file):

Previously, gbrodman wrote…

did you test this change with the local dev server? i remember this being finicky before

Yeah it actually stopped working after update, so this is what fixed it


console-webapp/src/app/settings/security/security.component.spec.ts line 61 at r3 (raw file):

Previously, gbrodman wrote…

what's this comment?

Removed, documentation copy-paste

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ptkach).

@ptkach ptkach added this pull request to the merge queue Feb 24, 2026
Merged via the queue into google:master with commit 49df9c3 Feb 24, 2026
10 checks passed
@ptkach ptkach deleted the depsUpdate branch February 24, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants