Add canary strategy to crash stage in Cloud Deploy pipeline#3057
Merged
Conversation
gbrodman
approved these changes
May 21, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jicelhay).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This maps the manifests that are being generated after #3048 to canary phases in the "deploy to crash" stage in the CD pipeline via crash-partial-phase-* skaffold profiles.
It also links the analysis phase to alerts in the "partialDeploymentAlertPolicyChecks" in the internal repo. The replacement is done in the release/cloudbuild-clouddeploy.yaml job (and fixes and issue with indentation in the script).
I ran the job manually to update the pipeline and results are as expected.
This change is